se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 426 forks source link

[#214] Fix misalignment of person names by changing index font #216

Closed baskar-gopinath closed 3 months ago

baskar-gopinath commented 3 months ago

Fixes #214

Explanation below image

image

canihasreview[bot] commented 3 months ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

canihasreview[bot] commented 3 months ago

v1

@baskar-gopinath submitted v1 for review.

(:books: Archive)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/216/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
damithc commented 3 months ago

I can't help wondering if there is an alternative solution that doesn't require using a different font just for the index. On a side note, this commit also seems to overwrite the change we did in the previous PR? Another question is whether this is worth fixing at all. Given that the name alignment will shift again when we move from single digit to double digit anyway.

baskargopinath commented 3 months ago

@damithc thats a good point it will become misaligned again when using double digits so i guess it isnt worth fixing as well

also, it didnt overwrite the change, the spacing has to be adjusted again due to the different font

damithc commented 3 months ago

Alright. Let's close this PR for now. We can reopen it later if needed. Sorry for not raising this point earlier.