Closed wltan closed 3 years ago
Click here to submit a new iteration when this PR is ready for review.
See this repository's contribution guide for more information.
@wltan submitted v1 for review.
Merging #65 (ba35277) into master (fb67d1f) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #65 +/- ##
=========================================
Coverage 72.18% 72.18%
Complexity 401 401
=========================================
Files 70 70
Lines 1233 1233
Branches 126 126
=========================================
Hits 890 890
Misses 311 311
Partials 32 32
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fb67d1f...ba35277. Read the comment docs.
@wltan
- As these are two different fixes, I think the PR should be split into two commits.
Ok, I've split the changes over two commits, each with a simple message body as well.
- The change to the activity diagram also requires an updated png file?
I've already created and pushed a new png for the updated diagram. Do any further changes need to be made?
@wltan if ready for review, you can use the bot to submit a new version (use the same link as before).
@wltan submitted v2 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2) (:chart_with_upwards_trend: Range-Diff between v1 and v2)
@wltan submitted v3 for review.
(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3) (:chart_with_upwards_trend: Range-Diff between v2 and v3)
Thanks for the fixes @wltan
Fixes #52