se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 430 forks source link

Fix miscellaneous typos #65

Closed wltan closed 3 years ago

wltan commented 3 years ago

Fixes #52

canihasreview[bot] commented 3 years ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

canihasreview[bot] commented 3 years ago

v1

@wltan submitted v1 for review.

(:books: Archive)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/65/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
codecov-io commented 3 years ago

Codecov Report

Merging #65 (ba35277) into master (fb67d1f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage     72.18%   72.18%           
  Complexity      401      401           
=========================================
  Files            70       70           
  Lines          1233     1233           
  Branches        126      126           
=========================================
  Hits            890      890           
  Misses          311      311           
  Partials         32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb67d1f...ba35277. Read the comment docs.

damithc commented 3 years ago

@wltan

  1. As these are two different fixes, I think the PR should be split into two commits.
  2. The change to the activity diagram also requires an updated png file? (@j-lum correct me if wrong).
wltan commented 3 years ago
  1. As these are two different fixes, I think the PR should be split into two commits.

Ok, I've split the changes over two commits, each with a simple message body as well.

  1. The change to the activity diagram also requires an updated png file?

I've already created and pushed a new png for the updated diagram. Do any further changes need to be made?

damithc commented 3 years ago

@wltan if ready for review, you can use the bot to submit a new version (use the same link as before).

canihasreview[bot] commented 3 years ago

v2

@wltan submitted v2 for review.

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2) (:chart_with_upwards_trend: Range-Diff between v1 and v2)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/65/2/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
canihasreview[bot] commented 3 years ago

v3

@wltan submitted v3 for review.

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3) (:chart_with_upwards_trend: Range-Diff between v2 and v3)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/65/3/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
damithc commented 3 years ago

Thanks for the fixes @wltan