se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 415 forks source link

Refine UG to state that extra parameters are ignored #67

Closed mehak24k closed 3 years ago

mehak24k commented 3 years ago

Fixes #60

canihasreview[bot] commented 3 years ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

damithc commented 3 years ago

Thanks for the fix @mehak24k Can you submit an update as per the bot comment above and also provide a full commit message as per https://se-education.org/guides/conventions/git.html ?

codecov-io commented 3 years ago

Codecov Report

Merging #67 (fb22116) into master (fb67d1f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage     72.18%   72.18%           
  Complexity      401      401           
=========================================
  Files            70       70           
  Lines          1233     1233           
  Branches        126      126           
=========================================
  Hits            890      890           
  Misses          311      311           
  Partials         32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb67d1f...fb22116. Read the comment docs.

canihasreview[bot] commented 3 years ago

v1

@mehak24k submitted v1 for review.

(:books: Archive)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/67/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
mehak24k commented 3 years ago

Thanks for the fix @mehak24k Can you submit an update as per the bot comment above and also provide a full commit message as per https://se-education.org/guides/conventions/git.html ?

Thank you for the feedback, I have refined the commit message and submitted an update with the bot.

damithc commented 3 years ago

Closing as it is fixed by another PR