search

se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 430 forks source link

Update UG to address issues #58 #62 #72

Closed Zhang-Yunjie closed 3 years ago

Zhang-Yunjie commented 3 years ago

Closes #62 Closes #58

canihasreview[bot] commented 3 years ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

codecov-io commented 3 years ago

Codecov Report

Merging #72 (529aeb1) into master (b3e3b78) will decrease coverage by 0.12%. The diff coverage is 70.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #72      +/-   ##
============================================
- Coverage     72.31%   72.18%   -0.13%     
- Complexity      400      409       +9     
============================================
  Files            70       70              
  Lines          1228     1280      +52     
  Branches        124      138      +14     
============================================
+ Hits            888      924      +36     
- Misses          308      321      +13     
- Partials         32       35       +3
Impacted Files Coverage Δ Complexity Δ
...a/seedu/address/logic/parser/ArgumentMultimap.java 60.00% <0.00%> (-40.00%) 7.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 97.22% <ø> (ø) 14.00 <0.00> (ø)
.../java/seedu/address/logic/commands/AddCommand.java 86.36% <72.72%> (-13.64%) 8.00 <1.00> (ø)
...java/seedu/address/logic/commands/EditCommand.java 93.67% <76.92%> (-3.35%) 12.00 <1.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 89.18% <81.81%> (-3.12%) 15.00 <0.00> (+4.00) :arrow_down:
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 10.00 <0.00> (+5.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3e3b78...529aeb1. Read the comment docs.

damithc commented 3 years ago

Thanks for the fix @Zhang-Yunjie Let's do two separate PRs as these are two different fixes. Easier to manage and faster to merge that way. Also, can you submit an update as per the bot comment above and also provide a full commit message as per https://se-education.org/guides/conventions/git.html ?

damithc commented 3 years ago

Closing due to inactivity