se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 430 forks source link

Unnecessary call to super() in StorageManager.java #83

Closed tlylt closed 2 years ago

tlylt commented 3 years ago

Hello, the call super() within the StorageManager class (line 23 -30) seems to be meaningless and could be removed to avoid misunderstanding:

    /**
     * Creates a {@code StorageManager} with the given {@code AddressBookStorage} and {@code UserPrefStorage}.
     */
    public StorageManager(AddressBookStorage addressBookStorage, UserPrefsStorage userPrefsStorage) {
        super();
        this.addressBookStorage = addressBookStorage;
        this.userPrefsStorage = userPrefsStorage;
    }

Discussion on this minor issue can be found here. Thank you.

damithc commented 3 years ago

Might apply to other similar classes as well. I noticed the same problem in at least one other class.