se-edu / addressbook-level3

:ab::three: Address Book sample application (Level 3)
https://se-education.org/addressbook-level3
MIT License
28 stars 414 forks source link

Missing inheritance in Storage class diagram #90 #91

Closed seanjyjy closed 3 years ago

seanjyjy commented 3 years ago

Fixes #90

updated class diagram: StorageClassDiagram

canihasreview[bot] commented 3 years ago

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

canihasreview[bot] commented 3 years ago

v1

@seanjyjy submitted v1 for review.

(:books: Archive)

Checkout this PR version locally ```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/91/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.
damithc commented 3 years ago

Thanks for the fix @seanjyjy Follow instructions in https://github.com/se-edu/addressbook-level3/pull/91#issuecomment-810761801 when the PR is ready for review

damithc commented 3 years ago

Follow instructions in #91 (comment) when the PR is ready for review

Sorry, you've done that already.

@se-edu/tech-team-level1 for your review please.

RuiFengg commented 3 years ago

LGTM, diagram shows Storage inheriting from UserPrefsStorage and AddressBookStorage Edit: Commit message could be more specific to describe the fix

Follow instructions in #91 (comment) when the PR is ready for review

Sorry, you've done that already.

@se-edu/tech-team-level1 for your review please.

seanjyjy commented 3 years ago

Thanks for the review, @RuiFengg The suggested changes to the commit message has been changed.

damithc commented 3 years ago

Thanks again both. Did some further revisions to the commit message before merging.