Closed seanjyjy closed 3 years ago
Click here to submit a new iteration when this PR is ready for review.
See this repository's contribution guide for more information.
@seanjyjy submitted v1 for review.
Thanks for the fix @seanjyjy Follow instructions in https://github.com/se-edu/addressbook-level3/pull/91#issuecomment-810761801 when the PR is ready for review
Follow instructions in #91 (comment) when the PR is ready for review
Sorry, you've done that already.
@se-edu/tech-team-level1 for your review please.
LGTM, diagram shows Storage inheriting from UserPrefsStorage and AddressBookStorage Edit: Commit message could be more specific to describe the fix
Follow instructions in #91 (comment) when the PR is ready for review
Sorry, you've done that already.
@se-edu/tech-team-level1 for your review please.
Thanks for the review, @RuiFengg The suggested changes to the commit message has been changed.
Thanks again both. Did some further revisions to the commit message before merging.
Fixes #90
updated class diagram: