Storage class diagram shows dependencies where associations are needed #93

[seanjyjy]

Fixes #93

Updated storage class diagram

[canihasreview[bot]]

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

[canihasreview[bot]]

v1

@seanjyjy submitted v1 for review.

• [v1 1/1] Update dependencies arrow into association between JsonSerializableAddressBook and JsonAdaptedPerson as well as between JsonAdaptedPerson and JsonAdaptedTag

(:books: Archive)

Checkout this PR version locally

```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/95/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.

[damithc]

@seanjyjy BTW, we can also add multiplicities for those arrows as well, to show that they are collections, not individual objects.

[seanjyjy]

Thanks for the review @JinHao-L and @damithc

I have updated the commit message and included the multiplicities for the arrow.

Updated Storage class diagram:

[damithc]

I have updated the commit message and included the multiplicities for the arrow.

That's good @seanjyjy . When ready, submit a new version using CIHR (as you did above).

Note that commit message has line length limits.

[codecov-commenter]

Codecov Report

Merging #95 (e6771e1) into master (16e139d) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #95   +/-   ##
=========================================
  Coverage     72.15%   72.15%           
  Complexity      399      399           
=========================================
  Files            70       70           
  Lines          1232     1232           
  Branches        125      125           
=========================================
  Hits            889      889           
  Misses          311      311           
  Partials         32       32           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16e139d...e6771e1. Read the comment docs.

[canihasreview[bot]]

v2

@seanjyjy submitted v2 for review.

• [v2 1/2] DG: Update Storage class diagram to update into association arrow
• [v2 2/2] Add multiplicities for the missing association arrow

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2) (:chart_with_upwards_trend: Range-Diff between v1 and v2)

Checkout this PR version locally

```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/95/2/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.

[canihasreview[bot]]

v3

@seanjyjy submitted v3 for review.

• [v3 1/2] DG: Update Storage class diagram to update into association arrow
• [v3 2/2] DG: Add multiplicities for the missing association arrows

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3) (:chart_with_upwards_trend: Range-Diff between v2 and v3)

Checkout this PR version locally

```sh git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/95/3/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you wish to fetch this PR to.

[damithc]

Thanks for the fix @seanjyjy I squashed the commits and rephrased the commit message to make it more compliant with our conventions.