[JavaFX-Part 4] Update FXML of DialogBox

[JiaXinEu]

Current:

Problem:

Text overrun may occur, and longer text will not be fully displayed but replaced with ellipsis instead.

Proposed:

Replace line with:

<Label fx:id="dialog" text="Label" wrapText="true" minHeight="-Infinity">

[damithc]

@flexibo any thoughts on this suggestion? I remember this aspect came up during the writing of part 5.

[flexibo]

@JiaXinEu @damithc ah yes, IIRC the issue is also fixed by removing the prefHeight for VBox. Either way works, will be great to update it in part 4.

[damithc]

@flexibo Thanks for the inputs. @JiaXinEu You can send a PR for this. It may be better to keep the original, point out the problem, and provide the two possible solutions.

[JiaXinEu]

Ok, submitted PR #37

[flexibo]

@damithc @JiaXinEu Actually I was wondering if it is better to just replace that line altogether using either one of the solutions (can just use JiaXinEu's solution). It might be a lot clearer for the students this way and avoid any confusion.

[damithc]

It might be a lot clearer for the students this way and avoid any confusion.

I'm fine with that too. Normally I prefer for students to learn about a problem and also how to solve it (rather than not encounter it at all) but this specific problem is not that important, so OK to avoid it entirely.

[JiaXinEu]

I have sent a PR based on this. #37

It may be better to keep the original, point out the problem, and provide the two possible solutions.

Perhaps I can create another PR for this so we can decide on which is better?

replace that line altogether using either one of the solutions

[damithc]

Perhaps I can create another PR for this so we can decide on which is better?

Sure @JiaXinEu