search

se-edu / guides

Style guides and tutorials for SE student projects
MIT License
5 stars 20 forks source link

[JavaFX - Part2] Additional tutorial for styling of components #29

Closed laney0808 closed 1 week ago

laney0808 commented 2 weeks ago

Current: "Styling" section only include those for containers and user input box. It also only gives instructions on styling to get the example UI, without much explanation.

Problem: Styling for dialog box elements is not specifically mentioned. It is only mentioned later in part 3, but it is more relevant to part 2. Furthermore, this part does mention that readers should refer to the official JavaFX documentation for a comprehensive list of properties to modify. However, some students may not read them especially when they are given a ready-for-use piece of code for their individual project.

Proposed: Also explore styling for Image View and text label. Mentions some of the most commonly-used properties for each element as examples. For example, wrapping in text label and scroll panel and binding of width and height can be mentioned. Provide explanation for lines of code whose purposes are not immediately understandable.

damithc commented 1 week ago

@laney0808 Check if the new 'Part 5' covers this aspect. If not, you can send a PR to propose your change (to part 2 or part 5).

laney0808 commented 1 week ago

new 'Part 5'

Hi Prof! I realized that part of it is mentioned in part 5, and the other part is already fixed in issue #29. I'll close this issue for now.