search

se-edu / guides

Style guides and tutorials for SE student projects
MIT License
5 stars 20 forks source link

[JavaFX - Part2] Change VBox to HBox #38

Open laney0808 opened 1 week ago

laney0808 commented 1 week ago

Current: ImageView and Label are shown as nodes in a VBox

Screenshot 2024-07-06 at 16 52 56

Problem: According to the mockup screenshot, the ImageView and Label are in a HBox which forms the DialogBox, and the DialogBoxes are stacked in a VBox as the content of the ScrollPane. Proposed: Under the "VBox" node, we should have: HBox -> VBox ImageView -> HBox Label -> HBox

damithc commented 1 week ago

@laney0808 What about the code given? Does it match the diagram or the mockup?

laney0808 commented 1 week ago

@laney0808 What about the code given? Does it match the diagram or the mockup?

Hi Prof! The code given does not seem to match the diagram or the mock up completely. The code for this part is only as detailed as the VBox (dialog container). It did not have dialog box (with HBox, ImageView, and Label). In the proposed version in #28, I already fixed the code by adding a sample dialog box. All that's left for this part is just to add a HBox as a container of ImageView and Label.