search

se-edu / guides

Style guides and tutorials for SE student projects
MIT License
5 stars 20 forks source link

Add labeled Mockup in Part 2 #40

Open laney0808 opened 1 week ago

laney0808 commented 1 week ago

Fix issue #27

laney0808 commented 1 week ago

Request to change: The structure is lacking a VBox inside the ScrollPane.

damithc commented 1 week ago

Request to change: The structure is lacking a VBox inside the ScrollPane.

@laney0808 can you elaborate?

laney0808 commented 1 week ago

Request to change: The structure is lacking a VBox inside the ScrollPane.

@laney0808 can you elaborate?

Hi Prof! I added this comment because I realized the new graph is lacking a label on the VBox. I'll add it in the next commit.

laney0808 commented 1 week ago

I like how this provides a clear idea of what the hierarchy graph will look like. Is Input one of the nodes too, or do you think it can be removed to avoid confusion? Perhaps something like this? I believe that's the text in the original UI.

Sure! let's change it to the new version to avoid confusion.

laney0808 commented 4 days ago

Requested change completed.

JiaXinEu commented 4 days ago

LGTM!