se-edu / guides

Style guides and tutorials for SE student projects
MIT License
7 stars 26 forks source link

Correct Duke scene graph by adding the HBox for dialog box #49

Closed laney0808 closed 3 months ago

damithc commented 4 months ago

@laney0808 This PR seems to overlap with #48?

laney0808 commented 4 months ago

@laney0808 This PR seems to overlap with #48?

Sorry, I just realized the older commits of this PR is the same as the other PRs. Please ignore the older commits and only review the newest commit (Correct the DukeSceneGraph). This new change should be independent of other PRs so there should not be conflicts.

damithc commented 4 months ago

@laney0808 I think you are creating new branches on top of older branches. You can close this PR, create a new branch (but switch to master branch first), cherry-pick the relevant commits from the older branch to the new branch, and send a PR from the new branch.