search

se-edu / guides

Style guides and tutorials for SE student projects
MIT License
7 stars 26 forks source link

[#26] Add padding for `img` component #58

Closed itstrueitstrueitsrealitsreal closed 3 months ago

itstrueitstrueitsrealitsreal commented 4 months ago

Fixes #26

Description:

Modified main.css to give img components a padding of 20px for improved readability as mentioned in #26.

Screenshots:

Before:

Screenshot 2024-07-20 at 4 17 35 PM

After:

Screenshot 2024-07-20 at 4 17 39 PM
damithc commented 4 months ago

🤔 I'm not sure about this. The image being close to text indicate they belong together, and reduces the amount of scrolling too. I don't think it hinders the reader that much. Also, this issue appears only when there is text immediately above the image and is separated by a <br>. So, a universal increase in margin may have wider impact than the necessary.

itstrueitstrueitsrealitsreal commented 4 months ago

Would it be preferable to leave it unchanged instead? Or are there any better alternatives?

damithc commented 4 months ago

Would it be preferable to leave it unchanged instead? Or are there any better alternatives?

Yes, for now, let's leave it as is. We can revisit it at a later time.

damithc commented 3 months ago

Closing this for now ...