Move footer and navbar to layout

se-edu / se-book

:book: Online Book: Software Engineering for Self-Directed Learners

https://se-edu.github.io/se-book/

42 stars 32 forks source link

Move footer and navbar to layout #64

Closed jamos-tay closed 5 years ago

jamos-tay commented 5 years ago

Move footer.md and navbar.md to layout and remove all references

damithc commented 5 years ago

Let me know when it is ready for review

jamos-tay commented 5 years ago

I think this one should be alright for now, I'll make separate PRs for other changes

damithc commented 5 years ago

Netlify preview doesn't show the nav-bar/footer. The current one is using the previous version of MarkBind as the PR was created before the feature was released.

damithc commented 5 years ago

I checked this again today. Still doesn't work. Probably due to https://github.com/MarkBind/markbind/issues/527

jamos-tay commented 5 years ago

Ah, I've checked it out, apparently the all pages were switched from page to default layout, but the files in the layout folder weren't copied over.