search

se-edu / se-book

:book: Online Book: Software Engineering for Self-Directed Learners
https://se-edu.github.io/se-book/
42 stars 32 forks source link

[#51, #52] Use 'you' and Sentence case #83

Closed Tejas2805 closed 4 years ago

Tejas2805 commented 4 years ago

Fixes part of #51 and #52 

Let's follow Google's documentation guidelines, to make the 
book more consistent.
Tejas2805 commented 4 years ago

Have done the following changes:

  1. Replace 'we' with 'you'.
  2. Modify sentence containing 'we' a bit to fit the 'you' context
  3. Use sentence case for headings based on Google documentation.
  4. Add EOF lines to files that don't have them.
Tejas2805 commented 4 years ago

@damithc Any specific reason for the deploy to fail? Otherwise, the PR is ready for review.

Tejas2805 commented 4 years ago

@damithc Can I get your review on this? Will do the second part accordingly.

damithc commented 4 years ago

Note that in general it is better to fix only one issue per PR, unless the issues are inter-dependent.

Tejas2805 commented 4 years ago

Note that in general it is better to fix only one issue per PR, unless the issues are inter-dependent.

Ya agreed. It's just that since I was going through all the files one by one, I went ahead with both. Will split up for the second part.

Tejas2805 commented 4 years ago

@damithc Can merge this, if all okay?