search

se-ok / WLsimilarity

informal exposition of Weisfeiler-Leman similarity
27 stars 3 forks source link

What is args.unit in main_TUs_kernels.py? #2

Closed williamweiwu closed 3 years ago

williamweiwu commented 3 years ago

Hi,

I have run the program, but there is a new issue in main_TUs_kernels.py.

In Line 184, _normalizer = 'unit' if args.unit else 'normal'. However, in def get_args() from Line 27 to 37, no 'unit' is provided.

How should I do it?

Thanks Wei

se-ok commented 3 years ago

Hi Wei,

I am sorry for the poor code. It is an artifact while simplifying experimental code to post. As you can see further down the code, line 184 is purely for logging, and you can replace it with _normalizer = 'normal'.

I checked the code running properly with script sh script_main_TUs_kernels.sh 0 BZR. I updated the repo too.

Thank you for reporting the issue, and let me know if there are further issues. Seongmin

williamweiwu commented 3 years ago

Hi Wei,

I am sorry for the poor code. It is an artifact while simplifying experimental code to post. As you can see further down the code, line 184 is purely for logging, and you can replace it with _normalizer = 'normal'.

I checked the code running properly with script sh script_main_TUs_kernels.sh 0 BZR. I updated the repo too.

Thank you for reporting the issue, and let me know if there are further issues. Seongmin

thx!