se701g2 / Doto

Todo application for Group 2
https://doto.azurewebsites.net/
MIT License
12 stars 42 forks source link

Incorrect callback URL port when developing #206

Closed jordansimsmith closed 4 years ago

jordansimsmith commented 4 years ago

Bug Summary:

When developing, create react app allows you to change the port (useful if you have something else running on port 3000). However, when authenticating on a non 3000 port, the callback url will assume you are on port 3000, and will not redirect you to the doto application.


Steps To Reproduce

1) Open another application on port 3000 2) Launch doto-frontend and select yes to opening on another port 3) attempt to login with google

Expected behaviour

Callback URL should be correct, you should be redirected back to doto after login.

Observed Behaviour

Callback URL was incorrect, redirects to the other application running on port 3000

Screenshots

If applicable, add screenshots to help explain your problem.

Environment


Additional Information:

Stack Traces

Test Cases

Code Examples

Error Reports

Other

Matteas-Eden commented 4 years ago

I'm tempted to say this bug is part of the design, given this extract from the README:

By default, the react-app is hosted on port 3000 and the local server is hosted on port 3001. Do not change these numbers as we have added the addresses as authorized redirect uri's in our google credentials.

jordansimsmith commented 4 years ago

I'm tempted to say this bug is part of the design, given this extract from the README:

By default, the react-app is hosted on port 3000 and the local server is hosted on port 3001. Do not change these numbers as we have added the addresses as authorized redirect uri's in our google credentials.

Good spotting, yeah I agree with you. I must have missed that part :laughing:. I'll close the issue.