issue/197 - Removed magic numbers in back-end and replaced with constants

[arangace]

-Removed magic numbers and replaced with more appropriate named constants. -resolves #197

• [ ] The pull request is complete according to the following criteria:
  • [x] Acceptance criteria have been met
  • [x] The documentation is kept up-to-date
  • [ ] Comprehensive tests (if applicable) have been generated and all pass.
  • [ ] The pull request describes the changes that have been made, and enough information is present in the description for any developer to understand what has changed
  • [ ] Commits have been squashed (or will be on merge).
  • [ ] The branch name is descriptive and follows the pull request title format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
  • [x] The pull request title is of the following format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
  • [x] The description uses github syntax to link to the issue. E,g Resolves se701g2/Doto#{Number}
  • [ ] At least two reviewers assigned. One of which must be the assigner of the issue.
  • [ ] If there are merge conflicts, run git rebase as opposed to git merge with master.

[arangace]

As the PR is only meant to refactor magic numbers in the backend, it shouldn't be updating the frontend snapshot.

Non-blocking question: why shorten names and keep others? "successful" vs "forbid", for instance?

I'm not sure why the front end is changed. I didn't edit it either. As for shortening names its just my personal preference, didn't think much about it. I'll update them to full names

[arangace]

Nice work @arangace.

Just a small request, we should not be recommitting package-lock.json as it was removed when migrating to yarn - #214. We are now relying on yarn.lock for this purpose.

yarn install --frozen-lockfile should be used for installations.

Got it! I'll remove it.