bug/252-Fix checkbox not updating by abstracting state away from component renders closes #252

[preetpatel]

• [x] The pull request is complete according to the following criteria:
  • [ ] Acceptance criteria have been met
  • [ ] The documentation is kept up-to-date
  • [ ] Comprehensive tests (if applicable) have been generated and all pass.
  • [ ] The pull request describes the changes that have been made, and enough information is present in the description for any developer to understand what has changed
  • [ ] Commits have been squashed (or will be on merge).
  • [ ] The branch name is descriptive and follows the pull request title format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
  • [ ] The pull request title is of the following format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
  • [ ] The description uses github syntax to link to the issue. E,g Resolves se701g2/Doto#{Number}
  • [ ] At least two reviewers assigned. One of which must be the assigner of the issue.
  • [ ] If there are merge conflicts, run git rebase as opposed to git merge with master.

[preetpatel]

It crosses out the task on the checklist and the task is marked as complete which is good. However, the actual checkbox doesn't get ticked. If there's no way to get the checkbox to be ticked through code then I guess it's alright since the actual task is marked as complete, but it's just a cosmetic problem.

It did the tick for me when i ran it.. thats weird

[preetpatel]

Hi @PreetPatel ,

Thanks for working on this bug. I think that I might have found a new bug while checking this code out locally. When first accessing Doto I get the following:

• After the authentication the following exception is thrown, "Unhandled Rejection (Type Error): Cannot read property 'themePreference". Although, there is a button to cross it out and proceed.
• This then loads the home page, when trying to create a new task the following is thrown: "Cannot read property 'forEach"

I have attached screenshots below for reference (To document with the bug).

NOTE: After doing a refresh everything works as supposed to and I do not get the issue @EricPedrido mentioned. Thanks for fix @PreetPatel 👍. Thus, since everything does seem to work I have gone ahead and approved the PR and will make a bug report for what I encountered, and hopefully, we can triangulate it soon.

Cheers thanks @harmanlamba I think the issue you're having is due to not properly going through the auth flow for google

[EricPedrido]

I do not get the issue @EricPedrido mentioned

Alright, well I assume it's a problem on my end then, I'll remove my change request but I won't be approving it just in case someone else gets this issue too. Nice work though, everything else looks good.

[jordansimsmith]

Hey @PreetPatel, can you elaborate on why this is a fix? It looks functionally equivalent to me.

[HarrisonLeach1]

Hey @PreetPatel, can you elaborate on why this is a fix? It looks functionally equivalent to me.

I agree, the behaviour from #252 can still be replicated. The checkbox should work without having to refresh the page.

[jordansimsmith]

Closing for now, feel free to reopen when its ready to be merged in :)

[preetpatel]

Rip.. just started working on it haha