se701g2 / Doto

Todo application for Group 2
https://doto.azurewebsites.net/
MIT License
12 stars 42 forks source link

Bug/232 Cannot add a new task on a selected date #263

Closed nikotj1 closed 4 years ago

nikotj1 commented 4 years ago

closes #232

jordansimsmith commented 4 years ago

@PreetPatel could you have a look at this please, I believe you recently changed this logic.

nikotj1 commented 4 years ago

LGTM, questionable about the comprehensive testing to be done, but if you can verify via a screenshot or something that'll be good! Nice work!

Thanks for the suggestion, screenshot attached: image

nikotj1 commented 4 years ago

I thought the idea of the task manager was to put in the tasks in the earliest coming up free time so that you could complete the task as early as possible. Correct me if I'm wrong, but right now this PR is looking like it gets added after the due date and time of the task - not particularly helpful if you have an asignment due then. Maybe it would be better to add in another input stating the start after date, specifying that you're only able to start the task after this date (so if I could only start it tomorrow, I'd specify tomorrow in the start after input and the task would then be made at that time

I genuinely misunderstood the application and perhaps the related issue could be improved, my bad.

I'm thinking of adding an extra field of earliest start time that would fulfill the same spirit of the related issue. I have created the new issue at #268