Fix frontend test - Githubissues

se701team3 / Forgettable

University of Auckland SOFTENG 701 Team 3 Assignment 1

MIT License

12 stars 44 forks source link

Fix frontend test #342

Closed harristomyx closed 2 years ago

harristomyx commented 2 years ago

Refactored some frontend tests to enable passable tests

Closes #336

mdar365 commented 2 years ago

I'm getting this error for EditPerson.test.js, is it working for you?

harristomyx commented 2 years ago

I like how you added error alerts in the EncountersListPage, which will make the application more user friendly. One thing you could improve on is adding comments. Other than that it looks good.

Will do, cheers

harristomyx commented 2 years ago

I'm getting this error for EditPerson.test.js, is it working for you?

Nah I think I got this at the start when auth wasn't setup properly but not now :/ Is .env and firebase-config unchanged when you switched to my fork?