search

seL4 / capdl

Capability Distribution Language tools for seL4
https://sel4.systems
35 stars 45 forks source link

python-capdl-tool: Update python3 test scripts #55

Closed kent-mcleod closed 1 year ago

kent-mcleod commented 1 year ago

.github action runners can just run tests with python3 only now.

Addresses https://github.com/seL4/capdl/issues/31

lsf37 commented 1 year ago

Thanks for that, I had forgotten about #31 already when I did #53. This fixes it properly.

I think we should explicitly test 3.9, 3.10, and 3.11 because they all failed in different ways before (apart from 3.9).

kent-mcleod commented 1 year ago

I think we should explicitly test 3.9, 3.10, and 3.11 because they all failed in different ways before (apart from 3.9).

But the tests are just testing certain functions of the python-capdl-tool and aren't comprehensive enough to deduce python version support. They only really need to pass on the version of python that's in the docker container IMO.

lsf37 commented 1 year ago

I think we should explicitly test 3.9, 3.10, and 3.11 because they all failed in different ways before (apart from 3.9).

But the tests are just testing certain functions of the python-capdl-tool and aren't comprehensive enough to deduce python version support.

They've been comprehensive enough to break for 3.10 and 3.11. If they pass it doesn't mean that much, but if they fail we'll at least know immediately that something is up.

They only really need to pass on the version of python that's in the docker container IMO.

Docker has 3.9, so it'd now be testing the wrong one.