search

seL4 / ci-actions

CI GitHub actions for the seL4 repositories
https://sel4.systems
3 stars 13 forks source link

Drop march from platforms.yml if there is no use #312

Open axel-h opened 8 months ago

axel-h commented 8 months ago

This is a follow-up from https://github.com/seL4/ci-actions/pull/283#discussion_r1301233100 to check if march has a deeper usage. If not, it could be removed to avoid confusion. Or replaced by something more clear as a selector. Seems the current fields that exist have a certain overlapping already from the history. Having the sel4arch as unification might be a way to go?

lsf37 commented 8 months ago

The main current use is as a selector in the hardware build matrix so that we can have multiple jobs for e.g. Arm (armv7a, armv8a, previously also armv6). They're not the same as Arm 32 bit and Arm 64 bit, although that could be another set of dimensions to use for slicing the build matrix.

E.g. we could drop march and split by (arch, mode, compiler). This would leave arm, 32, x as the two largest jobs, probably longer than the current armv8a jobs. So maybe one more dimension that would cut arm, 32, x roughly in half.

lsf37 commented 8 months ago

Maybe MCS, i.e. (arch, MCS on/off, mode, compiler). That should be roughly half the run time of the previous jobs.

axel-h commented 8 months ago

If the worry is the time, we could also group per platform. I tried this by having the python script generate the matrix from platforms.yml for builds also. Showing the results more nicely seems a separate thing anyway, see https://github.com/seL4/ci-actions/issues/130

lsf37 commented 8 months ago

You're right, we should probably at least try that.