Closed lsf37 closed 5 months ago
I'm not entirely sure why I had to downgrade sass-embedded from 1.54
to 1.53
, but I got dependency conflicts for anything > 1.53 and it's not like we're using this on untrusted input or are currently hitting bugs. Longer term it'd be nice to upgrade the Ruby version, but that's more time than I'm willing to spend today.
Tested with:
My main concern is that you seem to be manually editing Gemfile.lock. You should never do that, all changes should come via requests in Gemfile or bundler update or similar.
The commit is the result of bundle update
, with some versions constrained in Gemfile
(in the same commit) and the Ruby version (and therefore initial bundler version) pinned in .ruby-version
. This should be fully stable.
Rebased, addressed review feedback and documented in the commit message how Gemfile.lock was updated for the future.
That dependency caching for Ruby is quite nice. The build is much faster now.
rbenv
setup in README