search

seL4 / microkit

Microkit - A simple operating system framework for the seL4 microkernel
Other
79 stars 42 forks source link

Added maaxboard support with hello example #38

Closed josh-felm closed 8 months ago

Ivan-Velickovic commented 8 months ago

A couple requests:

Sorry for the confusion regarding the seL4 branch right now. I'll update the microkit branch of seL4 and so it'll contain the MaaXBoard support and then we can merge this.

Bill-James-Ellis commented 8 months ago

Hi, as per, https://github.com/seL4/seL4/pull/1164 is this pull request effectively blocked until sel4 (kernel) "microkit" branch is updated to have maxxboard support, as seen on the sel4 (kernel) master branch? (Is there a link or pull-request for that dependency change?)

Ivan-Velickovic commented 8 months ago

Hi, as per, seL4/seL4#1164 is this pull request effectively blocked until sel4 (kernel) "microkit" branch is updated to have maxxboard support, as seen on the sel4 (kernel) master branch? (Is there a link or pull-request for that dependency change?)

That's correct. This has been done in https://github.com/seL4/microkit/pull/93.

There were a couple things that needed changing, some minor style fixes but mainly the documentation in the manual for how to boot the image and also that the putc function didn't work initially, so I've fixed that myself.

Were the changes tested? Just because I couldn't get the hello world to work without making the change:

- #define TRANSMIT 0x49
+ #define TRANSMIT 0x40

Thanks for your patience.

Bill-James-Ellis commented 8 months ago

Hi, I'm pretty sure Josh tested this, but I'm not sure when, and in what configuration.

I have tried building from scratch with the merged code, using the head of main branch of microkit repo, and the documented commit (7008430d4432c71a74b2a1da0afae58f7a8658df) of microkit branch of sel4 repo, and it worked for me! I got "hello, world" over the serial TTY.

Note I used "debug" for MICROKIT_CONFIG -- I think the printing "hello" bit might depend on the kernel provided serial driver, which is only present in debug?

Note I can't find the "TRANSMIT 0x49" line anywhere? Do you know where that came from? The pull request, and our separate sel4-cap branch, all seem to have "TRANSMIT 0x40". Since the merged "0x40" seems to work, I guess that's fine, I'm just curious if there's another pull-request/branch/something I'm missing?

Ivan-Velickovic commented 8 months ago

Glad to hear it works for you as well!

Note I can't find the "TRANSMIT 0x49" line anywhere?

Weird, I looked at the original PR changes and 0x49 is not there, although when I force-pushed you can see in the diff at some point it was 0x49 https://github.com/seL4/microkit/compare/09003055e48d17f88725152c2922a49162959d4f..1dff9010c8f699f2575c5695135dab4999a8e78f. Not quite sure what's going on, but at least it works now.