seL4 / rust-sel4

Rust support for seL4 userspace
85 stars 10 forks source link

Fix release mode warnings and compile errors #121

Closed Ivan-Velickovic closed 2 months ago

Ivan-Velickovic commented 3 months ago

Regarding print macros not being available in release mode, I went with a similar approach as crates/sel4-microkit/src/printing.rs.

Ivan-Velickovic commented 3 months ago

Not sure if this is the right approach, or whether every kind of debug_print kind of macro should have two definitions, where one is a no-op for release mode?

nspin commented 2 months ago

Thanks for finding these issues!

I've implemented some slightly different fixes for the issues addressed in this PR in https://github.com/seL4/rust-sel4/pull/123.

I've also (finally) added some build tests to CI for release-style configurations.

I suggest closing this PR in favor of https://github.com/seL4/rust-sel4/pull/123

Ivan-Velickovic commented 2 months ago

Cool, thanks!