search

seL4 / seL4_libs

No-assurance libraries for rapid-prototyping of seL4 apps.
https://docs.sel4.systems
Other
51 stars 64 forks source link

Use constructor to initialise libc #21

Closed xurtis closed 4 years ago

xurtis commented 4 years ago

This initialises the C standard library using a constructor executed by the sel4runtime.

xurtis commented 4 years ago

@ssrg-bamboo test

ssrg-bamboo commented 4 years ago

Hello, I'm a bot! I'll bring this PR into Trustworthy Systems and run some tests

ssrg-bamboo commented 4 years ago

Test results for commit e90746bb50c2d5696079d0abf22cdd69abf28b85

Summary

Test name Result
Code Quality - Check licenses - seL4_libs - EXT-xurtis-init_constructor-21 SUCCESSFUL
Code Quality - Style - seL4_libs - EXT-xurtis-init_constructor-21 FAILED

Detailed failure logs

Project Stage Result summary
Code Quality - Style - seL4_libs - EXT-xurtis-init_constructor-21 Style check on changed files 1 of 3 jobs failed

Job: style Build logs

17-Sep-2020 10:00:29    Build Code Quality - Style - seL4_libs - EXT-xurtis-init_constructor-21 - style #1 (CQ-SEL4LIBSSTYLE66-SEL4LIBSSTYLEPR-1) started building on agent A local agent 1
17-Sep-2020 10:00:29    I run on the Bamboo server!
17-Sep-2020 10:00:29    Build working directory is /var/atlassian/application-data/bamboo/xml-data/build-dir/140083221/CQ-SEL4LIBSSTYLE66-SEL4LIBSSTYLEPR
17-Sep-2020 10:00:29    Executing build Code Quality - Style - seL4_libs - EXT-xurtis-init_constructor-21 - style #1 (CQ-SEL4LIBSSTYLE66-SEL4LIBSSTYLEPR-1)
17-Sep-2020 10:00:29    Preparing artifact 'code' for use at /var/atlassian/application-data/bamboo/xml-data/build-dir/140083221/CQ-SEL4LIBSSTYLE66-SEL4LIBSSTYLEPR/. (location: .)
17-Sep-2020 10:00:29    Artifact 'code' prepared in 22.15 ms at /var/atlassian/application-data/bamboo/xml-data/build-dir/140083221/CQ-SEL4LIBSSTYLE66-SEL4LIBSSTYLEPR/./code.tar.gz
17-Sep-2020 10:00:29    Running pre-build action: VCS Version Collector
17-Sep-2020 10:00:29    Starting task 'Untar code' of type 'com.atlassian.bamboo.plugins.scripttask:task.builder.script'
17-Sep-2020 10:00:29    + tar xf code.tar.gz --recursive-unlink
17-Sep-2020 10:00:29    Finished task 'Untar code' with result: Success
17-Sep-2020 10:00:29    Starting task 'Set permissions so Bamboo can cleanup' of type 'com.atlassian.bamboo.plugins.scripttask:task.builder.script'
17-Sep-2020 10:00:29    + chmod -R o+rwx /var/atlassian/application-data/bamboo/xml-data/build-dir/140083221/CQ-SEL4LIBSSTYLE66-SEL4LIBSSTYLEPR
17-Sep-2020 10:00:29    Finished task 'Set permissions so Bamboo can cleanup' with result: Success
17-Sep-2020 10:00:29    Starting task 'Check style of changed files' of type 'com.atlassian.bamboo.plugins.scripttask:task.builder.script'
17-Sep-2020 10:00:29    + cd seL4_libs
17-Sep-2020 10:00:29    ++ git merge-base e90746bb50c2d5696079d0abf22cdd69abf28b85 7853d576f016b25dbbb31af5e2b88d2cbd15ba7a
17-Sep-2020 10:00:29    + xargs -d '\n' /var/atlassian/application-data/bamboo/xml-data/build-dir/140083221/CQ-SEL4LIBSSTYLE66-SEL4LIBSSTYLEPR/seL4_tools/misc/style.sh
17-Sep-2020 10:00:29    + git diff --name-only e90746bb50c2d5696079d0abf22cdd69abf28b85 dc74a3a31b023b2522b0f1da2906f9a1149236ce
17-Sep-2020 10:00:29    Unchanged  libsel4muslcsys/src/vsyscall.c
17-Sep-2020 10:00:30    + git diff --exit-code
17-Sep-2020 10:00:30    diff --git a/libsel4muslcsys/CMakeLists.txt b/libsel4muslcsys/CMakeLists.txt
17-Sep-2020 10:00:30    index bb8415dd..c7ae46f9 100644
17-Sep-2020 10:00:30    --- a/libsel4muslcsys/CMakeLists.txt
17-Sep-2020 10:00:30    +++ b/libsel4muslcsys/CMakeLists.txt
17-Sep-2020 10:00:30    @@ -79,7 +79,7 @@ target_include_directories(sel4muslcsys PUBLIC include)
17-Sep-2020 10:00:30     target_link_libraries(
17-Sep-2020 10:00:30         sel4muslcsys
17-Sep-2020 10:00:30         PUBLIC
17-Sep-2020 10:00:30    -    # These quotes are needed to prevent cmake splitting these arguments
17-Sep-2020 10:00:30    +        # These quotes are needed to prevent cmake splitting these arguments
17-Sep-2020 10:00:30             "-Wl,-u -Wl,__vsyscall_ptr"
17-Sep-2020 10:00:30             muslc
17-Sep-2020 10:00:30             sel4
17-Sep-2020 10:00:30    Failing task since return code of [/var/atlassian/application-data/bamboo/temp/CQ-SEL4LIBSSTYLE66-SEL4LIBSSTYLEPR-1-ScriptBuildTask-8014156292036226439.sh] was 1 while expected 0
17-Sep-2020 10:00:30    Finished task 'Check style of changed files' with result: Failed
17-Sep-2020 10:00:30    Starting task 'Set permissions so Bamboo can cleanup' of type 'com.atlassian.bamboo.plugins.scripttask:task.builder.script'
17-Sep-2020 10:00:30    + chmod -R o+rwx /var/atlassian/application-data/bamboo/xml-data/build-dir/140083221/CQ-SEL4LIBSSTYLE66-SEL4LIBSSTYLEPR
17-Sep-2020 10:00:30    Finished task 'Set permissions so Bamboo can cleanup' with result: Success
17-Sep-2020 10:00:30    Starting task 'Run astyle code insights' of type 'com.atlassian.bamboo.plugins.scripttask:task.builder.script'
17-Sep-2020 10:00:30    + cd seL4_libs
17-Sep-2020 10:00:30    ++ echo ssh://git@bitbucket.keg.ertos.in.nicta.com.au:7999/sel4/sel4_libs.git
17-Sep-2020 10:00:30    ++ cut -d/ -f4
17-Sep-2020 10:00:30    + bb_proj=sel4
17-Sep-2020 10:00:30    + /scripts/bb_code_insights/create_code_insights.sh astyle sel4 seL4_libs
17-Sep-2020 10:00:30    ++ dirname /scripts/bb_code_insights/create_code_insights.sh
17-Sep-2020 10:00:30    + SCRIPT_DIR=/scripts/bb_code_insights
17-Sep-2020 10:00:30    + BBS_URL=https://bitbucket.ts.data61.csiro.au
17-Sep-2020 10:00:30    + BBS_PROJECT=sel4
17-Sep-2020 10:00:30    + BBS_REPO=seL4_libs
17-Sep-2020 10:00:30    + REPORT_TO_RUN=astyle
17-Sep-2020 10:00:30    ++ git rev-parse HEAD
17-Sep-2020 10:00:30    + COMMIT_ID=e90746bb50c2d5696079d0abf22cdd69abf28b85
17-Sep-2020 10:00:30    + REPORT_KEY=astyle.report
17-Sep-2020 10:00:30    + set +x
17-Sep-2020 10:00:30    + report_file=astyle_report.json
17-Sep-2020 10:00:30    + annotations_file=astyle_annotations.json
17-Sep-2020 10:00:30    + rm -f astyle_report.json astyle_annotations.json
17-Sep-2020 10:00:30    + /scripts/bb_code_insights/astyle
17-Sep-2020 10:00:33    Reporting on these files:  ['libsel4bench/sel4_arch_include/aarch64/sel4bench/sel4_arch/sel4bench.h', 'libsel4muslcsys/src/vsyscall.c', 'libsel4muslcsys/CMakeLists.txt']
17-Sep-2020 10:00:33    Reporting the results to BitBucket, but doing so *secretly*, so people don't see the access token
17-Sep-2020 10:00:33    + echo 'Reporting the results to BitBucket, but doing so *secretly*, so people don'\''t see the access token'
17-Sep-2020 10:00:33    + set +x
17-Sep-2020 10:00:33    + '[' -f astyle_report.json ']'
17-Sep-2020 10:00:33    + cat astyle_report.json
17-Sep-2020 10:00:33    + '[' -f astyle_annotations.json ']'
17-Sep-2020 10:00:33    + cat astyle_annotations.json
17-Sep-2020 10:00:33    {"data":[{"title":"Total number of files with incorrect style","value":1},{"title":"Total number of lines with incorrect style","value":1}],"createdDate":1600300833665,"key":"astyle.report","title":"Code style"}{"title": "Code style", "data": [{"title": "Total number of files with incorrect style", "value": 1}, {"title": "Total number of lines with incorrect style", "value": 1}]}{"annotations": [{"path": "libsel4muslcsys/CMakeLists.txt", "line": 82, "message": "There are 1 line(s) of incorrect style here.", "severity": "HIGH"}]}
17-Sep-2020 10:00:33    Finished task 'Run astyle code insights' with result: Success
17-Sep-2020 10:00:33    Running post build plugin 'NCover Results Collector'
17-Sep-2020 10:00:33    Running post build plugin 'Artifact Copier'
17-Sep-2020 10:00:33    Running post build plugin 'npm Cache Cleanup'
17-Sep-2020 10:00:33    Running post build plugin 'Clover Results Collector'
17-Sep-2020 10:00:33    Running post build plugin 'Docker Container Cleanup'
17-Sep-2020 10:00:34    Successfully removed working directory at '/var/atlassian/application-data/bamboo/xml-data/build-dir/140083221/CQ-SEL4LIBSSTYLE66-SEL4LIBSSTYLEPR'
17-Sep-2020 10:00:34    Finalising the build...
17-Sep-2020 10:00:34    Stopping timer.
17-Sep-2020 10:00:34    Build CQ-SEL4LIBSSTYLE66-SEL4LIBSSTYLEPR-1 completed.
17-Sep-2020 10:00:34    Running on server: post build plugin 'NCover Results Collector'
17-Sep-2020 10:00:34    Running on server: post build plugin 'Build Hanging Detection Configuration'
17-Sep-2020 10:00:34    Running on server: post build plugin 'Clover Delta Calculator'
17-Sep-2020 10:00:34    Running on server: post build plugin 'Maven Dependencies Postprocessor'
17-Sep-2020 10:00:34    All post build plugins have finished
17-Sep-2020 10:00:34    Generating build results summary...
17-Sep-2020 10:00:34    Saving build results to disk...
17-Sep-2020 10:00:34    Store variable context...
17-Sep-2020 10:00:34    Indexing build results...
17-Sep-2020 10:00:34    Finished building CQ-SEL4LIBSSTYLE66-SEL4LIBSSTYLEPR-1.

This is the most I can report on right now, sorry!

xurtis commented 4 years ago

@ssrg-bamboo test

ssrg-bamboo commented 4 years ago

Hello, I'm a bot! I'll bring this PR into Trustworthy Systems and run some tests

ssrg-bamboo commented 4 years ago

All the tests we ran have passed! Nice job!

xurtis commented 4 years ago

@ssrg-bamboo test

ssrg-bamboo commented 4 years ago

Hello, I'm a bot! I'll bring this PR into Trustworthy Systems and run some tests

ssrg-bamboo commented 4 years ago

All the tests we ran have passed! Nice job!