fix CFILES in Makefile for x86

seL4 / seL4_libs

No-assurance libraries for rapid-prototyping of seL4 apps.

https://docs.sel4.systems

Other

52 stars 62 forks source link

fix CFILES in Makefile for x86 #3

Closed ficoos closed 7 years ago

ficoos commented 7 years ago

The makefile is using the wrong path variables for arch.

ARCH=x86 SEL4_ARCH=ia32

AdrianDanis commented 7 years ago

Hi @ficoos,

Thanks for noticing this. Unfortunately I have to ask if you have signed a CLA? As this is required for us to accept changes to this repository.

On the change itself, I would suggest doing the additional couple of things

Rename the libsel4debug/src/arch/arm directory to libsel4debug/src/arch/aarch32 to reflect your change of ARCH->SEL4_ARCH
Rename libsel4debug/src/arch to libsel4debug/src/sel4_arch to reflect that this is now a sel4_arch and not just an arch directory

ficoos commented 7 years ago

Updated according to comments. I also sent the signed CLA.

AdrianDanis commented 7 years ago

Thanks @ficoos ! Looks good to me now. Once it runs through our regression system it'll get merged (could be a few days as some things are currently broken)