search

seL4 / seL4_libs

No-assurance libraries for rapid-prototyping of seL4 apps.
https://docs.sel4.systems
Other
52 stars 62 forks source link

libsel4debug: use proper closing bracket #55

Closed axel-h closed 2 years ago

axel-h commented 2 years ago

use proper closing bracket in the debug output

kent-mcleod commented 2 years ago

use proper closing bracket in the debug output

The closing bracket is already correct. The proposed change would mean it no longer matches with the opening bracket. The output isn't trying to be mathematical notation.

I don't think there is a good enough motivation for this change. This output has already been used for several years and there's some value in it maintaining a consistent syntax across multiple versions.

axel-h commented 2 years ago

The closing bracket is already correct. The proposed change would mean it no longer matches with the opening bracket.

@kent-mcleod: I'm confused now. The opening bracket it [ and the closing bracket is ). My proposal is changing the closing bracket to ] to match the opening bracket.

kent-mcleod commented 2 years ago

@kent-mcleod: I'm confused now. The opening bracket it [ and the closing bracket is ). My proposal is changing the closing bracket to ] to match the opening bracket.

Sorry, I don't know what I was thinking here. @lsf37 points out that the notation is currently following mathematical range notation to communicate that the end values are exclusive not inclusive (https://en.wikipedia.org/wiki/Interval_(mathematics)#Including_or_excluding_endpoints) which I believe means that the brackets were intentionally mismatched.

pingerino commented 2 years ago

Yes, the brackets were intentionally mismatched.