search

seL4 / seL4_libs

No-assurance libraries for rapid-prototyping of seL4 apps.
https://docs.sel4.systems
Other
52 stars 62 forks source link

trivial: match ifdef around map_iospace_page #67

Closed chrisguikema closed 1 year ago

chrisguikema commented 1 year ago

Match the function implementation

lsf37 commented 1 year ago

It looks to me like the function implementation is using the wrong ifdef, not the header. I.e. it makes sense to me to check for presence of IOMMU here, not for architecture.

chrisguikema commented 1 year ago

Updated to check for the presence of an IOMMU, SMMU, or TK1_SMMU. Also matched the declaration and implementation.

kent-mcleod commented 1 year ago

Updated to check for the presence of an IOMMU, SMMU, or TK1_SMMU. Also matched the declaration and implementation.

I don't think that these functions are supported for CONFIG_ARM_SMMU because it doesn't have separate page tables or mapping invocations and uses the normal invocations instead?

chrisguikema commented 1 year ago

I'll let @Furao or @Apave24 chime in here. They'd have more insight on the ARM_SMMU specifics than myself.