search

seL4 / seL4_libs

No-assurance libraries for rapid-prototyping of seL4 apps.
https://docs.sel4.systems
Other
52 stars 62 forks source link

simple: Define SIMPLE_SKIPPED_INIT_CAPS better #76

Closed Furao closed 10 months ago

Furao commented 10 months ago

Make sure this macro is defined based on all possible configurations.

Required based on this change: https://github.com/seL4/seL4/pull/1088

kent-mcleod commented 10 months ago

Thanks for putting this PR up @Furao ,

I think simple_default_nth_cap needs to also be updated to skip over the null caps correctly. It looks like it currently only handles the special x86 caps at the moment.

I think this also needs to account for seL4_CapSMMUSIDControl and seL4_CapSMMUCBControl caps which would be null if SMMUv2 isn't enabled.

Furao commented 10 months ago

Thanks for putting this PR up @Furao ,

No Problem

I think simple_default_nth_cap needs to also be updated to skip over the null caps correctly. It looks like it currently only handles the special x86 caps at the moment.

I think this also needs to account for seL4_CapSMMUSIDControl and seL4_CapSMMUCBControl caps which would be null if SMMUv2 isn't enabled.

Ok, I updated that function. I looked at that a bit ago when Axel first brought this issue up on the SMC patches, but I was confused by this function. That explains why.