search

seL4 / seL4_libs

No-assurance libraries for rapid-prototyping of seL4 apps.
https://docs.sel4.systems
Other
52 stars 62 forks source link

Added missing constants and functions for Beaglebone Black #8

Closed fabriziobertocci closed 6 years ago

fabriziobertocci commented 6 years ago

The missing constants and functions are used in util_libs/libethdrivers and are needed in order to build for Beaglebone black. Now, even after those missing macros & functions I still don't have the lwip+ethdriver working on BBB (yet), but at least I get it to build.

AdrianDanis commented 6 years ago

Hi @fabriziobertocci thanks for the contribution. Unfortunately we need a CLA to be signed for contributions to this repository.

fabriziobertocci commented 6 years ago

Adrian, Yes, I totally forgot about the CLA. I have sent the document for review to our legal department. As soon as it is approved I'll sign it and submit it. I have other bug fix to commit (in util_lis/libethdrivers).

Regards, Fabrizio

On Wed, Jun 6, 2018 at 9:20 PM, Adrian Danis notifications@github.com wrote:

Hi @fabriziobertocci https://github.com/fabriziobertocci thanks for the contribution. Unfortunately we need a CLA https://docs.sel4.systems/Contributing to be signed for contributions to this repository.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seL4/seL4_libs/pull/8#issuecomment-395262591, or mute the thread https://github.com/notifications/unsubscribe-auth/AHsRyaqoUan5jVDfMmMrNikhXdtqh9oPks5t6H_ogaJpZM4UdSbi .

AdrianDanis commented 6 years ago

No worries. Feel free to put up any other PRs for review and we can merge them once the CLA comes in.

fyi I have no issues with this PR

fabriziobertocci commented 6 years ago

All right I'll do the other one as well then.

FYI, I have managed to build a network test app on the beaglebone (after those fixes), but I haven't completed my IRQ handler yet (so I couldn't run the tests). On the other hand, I did managed to get our UDP test app to run on a iMX6 board (using lwip), but that required some long debugging as there are some issues in libethdrivers (in the creation of the RX ring buffer). After that, UDP works but it appears that fragmentation is broken (I haven't investigated why yet since right now I don't need fragmentation for my tests). I have not tested TCP yet.

Regards, Fabrizio

On Wed, Jun 6, 2018 at 9:57 PM, Adrian Danis notifications@github.com wrote:

No worries. Feel free to put up any other PRs for review and we can merge them once the CLA comes in.

fyi I have no issues with this PR

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seL4/seL4_libs/pull/8#issuecomment-395268251, or mute the thread https://github.com/notifications/unsubscribe-auth/AHsRyRtpTdP18hDk77YIuh2ju1r_VmX7ks5t6IiQgaJpZM4UdSbi .

fabriziobertocci commented 6 years ago

Adrian, You should have received the CLA signed by our legal dept. I have also submitted another pull request. Let me know if there are any problems. Regards, Fabrizio

On Wed, Jun 6, 2018 at 10:05 PM, Fabrizio Bertocci < fabriziobertocci@gmail.com> wrote:

All right I'll do the other one as well then.

FYI, I have managed to build a network test app on the beaglebone (after those fixes), but I haven't completed my IRQ handler yet (so I couldn't run the tests). On the other hand, I did managed to get our UDP test app to run on a iMX6 board (using lwip), but that required some long debugging as there are some issues in libethdrivers (in the creation of the RX ring buffer). After that, UDP works but it appears that fragmentation is broken (I haven't investigated why yet since right now I don't need fragmentation for my tests). I have not tested TCP yet.

Regards, Fabrizio

On Wed, Jun 6, 2018 at 9:57 PM, Adrian Danis notifications@github.com wrote:

No worries. Feel free to put up any other PRs for review and we can merge them once the CLA comes in.

fyi I have no issues with this PR

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seL4/seL4_libs/pull/8#issuecomment-395268251, or mute the thread https://github.com/notifications/unsubscribe-auth/AHsRyRtpTdP18hDk77YIuh2ju1r_VmX7ks5t6IiQgaJpZM4UdSbi .

AdrianDanis commented 6 years ago

@fabriziobertocci There was an issue with the CLA mailing address over the weekend that has since been fixed, but I fear your CLA was most probably lost to it. Can I ask that you have it sent again? Sorry about that.

fabriziobertocci commented 6 years ago

Hi Adrian, Done, this time I have put your email address in CC. Regards, Fabrizio

On Mon, Jun 11, 2018 at 11:23 PM, Adrian Danis notifications@github.com wrote:

@fabriziobertocci https://github.com/fabriziobertocci There was an issue with the CLA mailing address over the weekend that has since been fixed, but I fear your CLA was most probably lost to it. Can I ask that you have it sent again? Sorry about that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seL4/seL4_libs/pull/8#issuecomment-396453538, or mute the thread https://github.com/notifications/unsubscribe-auth/AHsRydIfHH7CqHuy0KZW4aMK_cSkqqtqks5t7zQUgaJpZM4UdSbi .