seL4 / seL4_projects_libs

Other
19 stars 36 forks source link

libsel4vmmplatsupport: use vm->entry for zImage also #94

Open axel-h opened 1 year ago

axel-h commented 1 year ago

This is a follow-up from the change introduced by https://github.com/seL4/seL4_projects_libs/pull/81

axel-h commented 1 year ago

To me, the vm->entry usage seems quite strange. Loading behavior of the kernel depends on the image type:

So it seems vm->entry is slightly misused in what we have currently? Looks like there should be a vm->kernel_addr also that must be given in case the kernel is a raw binary.

axel-h commented 1 year ago

With the changes of this PR it seems we don't really need 'vm.entry' that 58dc2820 recently added (https://github.com/seL4/seL4_projects_libs/pull/81). We should instead pass the value in load_base_addr, as this parameter has been practically unused. That would nicely simplify things then.