search

seL4 / sel4test

Test suite for seL4.
http://sel4.systems
Other
25 stars 63 forks source link

add missing return statement (fix #47) #49

Closed axel-h closed 3 years ago

axel-h commented 3 years ago

add missing return statement as fix https://github.com/seL4/sel4test/issues/47 for. @yyshen suggested just to return 0 here, but this seem to contradict what all other test are doing.

lsf37 commented 3 years ago

The function sched0022_to_fn() is not itself a test, it's only a helper function inside a test. There are plenty of these helper functions that do return 0, e.g. in the same file prio_test_func:

https://github.com/seL4/sel4test/blob/a9d3d683c04ecab5a1a4f4b00238044f24c72b24/apps/sel4test-tests/src/tests/scheduler.c#L252-L266

I think return 0 is right here. sel4test_get_result() will probably not do anything bad, because the return value of sched0022_to_fn() is ignored anyway in this test, but it's not what is expected at that point.

axel-h commented 3 years ago

change.