search

seL4 / sel4test

Test suite for seL4.
http://sel4.systems
Other
25 stars 61 forks source link

Set SIMULATION for Spike platform by default #79

Closed Ivan-Velickovic closed 1 year ago

Ivan-Velickovic commented 2 years ago

The following command for building seL4test for the Spike (as documented here https://docs.sel4.systems/Hardware/spike.html) will not compile: ../init-build.sh -DPLATFORM=spike -DRISCV64=1. This is because the CMake variable SIMULATION is not set so seL4test is trying to initialise a timer for the Spike, which isn't implemented. This patch turns SIMULATION on for the Spike by default, matching the behaviour for the QEMU AArch64 virt platform.

axel-h commented 2 years ago

Seems the github CI workflows set SIMULATION=TRUE automatically, so this issues did never popped up here.

axel-h commented 1 year ago

@lsf37 yes. Sorry, I did not pay attention to that detail. Shame on me.

lsf37 commented 1 year ago

@lsf37 yes. Sorry, I did not pay attention to that detail. Shame on me.

No worries, the merge on seL4 actually turned out to be good, because my re-run from last night didn't pick up the sel4test merge (which I think is the correct behaviour, I just forgot that it would do that). Anyway, I hope we'll be able to sort out the remaining issues today.

lsf37 commented 1 year ago

The imx8mq2 board is broken (issues with the serial port), so I've disabled that for now and we can merge again.