search

seL4 / util_libs

Other
55 stars 83 forks source link

Prelim zynqmp ethdrivers support #139

Closed chrisguikema closed 1 year ago

chrisguikema commented 1 year ago

This PR adds preliminary libethdrivers support for the zynqmp platform.

We have additional work bringing it up to the driver framework, integrating it with the Ethdriver component, and an example webserver application. I just wanted to put this out for preliminary review with the understanding we'll improve on it once the additional features are approved for release.

axel-h commented 1 year ago

Could you fix the license identifier to use SPDX, please?

chrisguikema commented 1 year ago

Alright, I ended up just reworking these commits to pull the updated zynq7000 libethdrivers, and then applied all the style patches so the checks would pass.

This should be good to review and merge, as it doesn't prevent the builds. And then DornerWorks will make some additional PRs to utilize the library when the code is approved for release.

kent-mcleod commented 1 year ago

Alright, I ended up just reworking these commits to pull the updated zynq7000 libethdrivers, and then applied all the style patches so the checks would pass.

So U-Boot has a single driver for zynq7000 and zynqmp, zynq_gem.c? Is the new driver in this PR synced with upstream U-Boot, or is it just based off the forked one in zynq7000/ from this library?

chrisguikema commented 1 year ago

Is the new driver in this PR synced with upstream U-Boot, or is it just based off the forked one in zynq7000/ from this library?

zynq_gem.c was copied from the forked one in libethdrivers/src/plat/zynq7000

chrisguikema commented 1 year ago

@kent-mcleod Can this be merged?