CMake cleanup - Githubissues

seL4 / util_libs

Other

53 stars 83 forks source link

CMake cleanup #156

Closed axel-h closed 1 year ago

axel-h commented 1 year ago

use variables instead of string matching
merge target_include_directories() statements

axel-h commented 1 year ago

Sorry, rebased this to the wrong base accidentally. Can we merge this, that would help avoiding conflicts with some other changes.

axel-h commented 1 year ago

seem the build errors for the hardware platforms are unrelated to this change, looks more like a network/mount issue?

lsf37 commented 1 year ago

seem the build errors for the hardware platforms are unrelated to this change, looks more like a network/mount issue?

The power supply for a lot of boards died -- a new one is now active, but the boards tx1 and zcu102_2 are still acting up. I'm hoping Peter will be able to fix them by tomorrow.

axel-h commented 1 year ago

Can we merge this? It has passed the CI test at least once, the failures are random CI Board issues.

lsf37 commented 1 year ago

The boards should be much more stable again now, I've restarted the test. It'd be nice if at least the imx8mq ran successfully, because the PR mentions it.

If MULTICORE004 fails for the imx8mq on smp+hyp with clang, then that's unrelated to this PR.