seL4 / util_libs

Other
53 stars 83 forks source link

libfdt: Add 32/64-bit fdt_appendprop_uint() #162

Closed hlyytine closed 1 year ago

hlyytine commented 1 year ago

Adds a convenience function that reduces the number of 'if' statements in the code, since #cells required is given as a parameter.

hlyytine commented 1 year ago

Seems that style check fails, even though libfdt shouldn't be checked against seL4 style rules. I just can't remember what file I am supposed to add to bypass the check for this?

lsf37 commented 1 year ago

Seems that style check fails, even though libfdt shouldn't be checked against seL4 style rules.

Indeed.

I just can't remember what file I am supposed to add to bypass the check for this?

I think the file is .stylefilter at the root of the repo.

axel-h commented 1 year ago

We could create a libftd-ext.h (that libftd.h includes) and libftd-ext.c where we put our extension. That would keep the modification to the 3rd party libftd minimal, so we could pick update there more easily.

But for this minimal extension that seem to be more difficult than useful.

axel-h commented 1 year ago

I think the file is .stylefilter at the root of the repo.

It has libfdt in there, but his does not work. Using libfdt/* seems to be the proper expression to use.

hlyytine commented 1 year ago

Note that seL4/sel4_projects_libs#108 is also required (just found out you had accepted seL4/camkes-vm#107, but the other repo does not have reviews)

hlyytine commented 1 year ago

It has libfdt in there, but his does not work. Using libfdt/* seems to be the proper expression to use.

That did the trick, thanks.

axel-h commented 1 year ago

It has libfdt in there, but his does not work. Using libfdt/* seems to be the proper expression to use.

That did the trick, thanks.

Could you make the stylefilter change a separate commit?

axel-h commented 1 year ago

Note that seL4/seL4_projects_libs#108 is also required (just found out you had accepted seL4/camkes-vm#107, but the other repo does not have reviews)

For this PR here it is not needed, it just depends on it. Or did I ger something wrong?

hlyytine commented 1 year ago

For this PR here it is not needed, it just depends on it. Or did I ger something wrong?

Never mind, it was just too early morning for me.