search

seL4 / util_libs

Other
55 stars 85 forks source link

SERIAL_AUTO_CR inconsistently implemented #48

Open bennoleslie opened 4 years ago

bennoleslie commented 4 years ago

In some implementation (rockpro64) the CR is sent after the LF, while in others (such as imx) it is sent prior to the LF.

I think it should be sent prior (as in, imx is correct). Is there a reason the rockpro64 is implemented differently?

axel-h commented 4 years ago

yes this is a copy&paste bug that keeps spreading. I've already upstreamed a few patches that fix this for the platform I have access to.

See also https://github.com/seL4/util_libs/pull/38#discussion_r484764026