search

seL4 / util_libs

Other
55 stars 83 forks source link

Add odroidc4 support #97

Closed xurtis closed 3 years ago

xurtis commented 3 years ago

This adds support for the ODroidC4. The ODroidC4 is just a beefier ODroidC2 with some bits moved around. The devices we care about here are all essentially the same.

nomadeel commented 3 years ago

Given that the devices for the C2 and the C4 are the same, would it be better to put the drivers in a common location where both platforms can access them?

xurtis commented 3 years ago

Given that the devices for the C2 and the C4 are the same, would it be better to put the drivers in a common location where both platforms can access them?

The driver implementations are the same, yes, only the headers are different. I could use symlinks for the the .c files for now. I don't think our build system has anything particularly nice for dealing with common devices at the moment.

xurtis commented 3 years ago

@nomadeel I've updated this to only introduce new files for address & IRQ differences, everything else is referenced to the odroidc2 using symlinks.

nomadeel commented 3 years ago

What you could probably do is this: https://github.com/seL4/util_libs/blob/master/libethdrivers/CMakeLists.txt#L66 and https://github.com/seL4/util_libs/blob/master/libplatsupport/CMakeLists.txt#L111. But even then it's no different than the symlink solution here.

nomadeel commented 3 years ago

Regardless of whatever solution you take, it looks good to me so far.