Closed sea-bass closed 1 month ago
Coverage Report
Tests | Skipped | Failures | Errors | Time |
---|---|---|---|---|
168 | 0 :zzz: | 0 :x: | 0 :fire: | 3m 3s :stopwatch: |
We are in business.
I tested both the docker and non-docker workflows on MacOS (I skipped my VM).
The only caveat for using Docker is setting
DISPLAY=host.docker.internal:0
in the compose file but meh.
Is this a MacOS specific thing? We can add some doc instructions or something for that?
Is this a MacOS specific thing? We can add some doc instructions or something for that?
I would say it's not worth managing documentation for getting containers on MacOS access to DISPLAY
, it's a headache that doesn't seem to have one solution. I'm just using what's worked for me. Maybe we could just add a comment to the compose file saying that this works on Ubuntu but other OS's might have specific needs?
This PR switches from
PyQt5
(GPL license) toPySide6
(LGPL license, not restrictive if you dynamically link as in this case).It should also better support macOS (see https://wiki.qt.io/Qt_for_Python) -- @eholum can you check how this one works for you?