search

sea-bass / turtlebot3_behavior_demos

Example repository for autonomous behaviors using TurtleBot3, as well as Docker workflows in ROS based projects.
MIT License
270 stars 53 forks source link

`make build` fails #1

Closed trunc8 closed 3 years ago

trunc8 commented 3 years ago

Hi, the error message is as follows:

Sending build context to Docker daemon  2.907MB
Step 1/15 : FROM nvidia_ros:latest
pull access denied for nvidia_ros, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
make: *** [Makefile:48: build-base] Error 1

Is nvidia_ros not a standard DockerHub image? It would be great if you could prepend those steps in the instructions. Kudos to the corresponding blog post though! I learnt a lot from that

sea-bass commented 3 years ago

Thank you!

Actually, nvidia_ros is not a standard Docker Hub image, but there already was a build-core target in the Makefile to build this... I just forgot to add the dependency. Thanks for pointing this out, and I think I just fixed it.

Try pulling again and see if it works?

# Build the core image
.PHONY: build-core
build-core:
    @docker build -f ${CORE_DOCKERFILE} -t nvidia_ros .

# Build the base image (depends on core image build)
.PHONY: build-base
build-base: build-core
    @docker build -f ${BASE_DOCKERFILE} -t ${IMAGE_NAME}_base .

# Build the overlay image (depends on base image build)
.PHONY: build
build: build-base
    @docker build -f ${OVERLAY_DOCKERFILE} -t ${IMAGE_NAME}_overlay .
trunc8 commented 3 years ago

Thanks, make build works now