refactor: remove repeated parts and use ports more

sea-bass / turtlebot3_behavior_demos

Example repository for autonomous behaviors using TurtleBot3, as well as Docker workflows in ROS based projects.

MIT License

270 stars 53 forks source link

refactor: remove repeated parts and use ports more #22

Closed bektaskemal closed 1 year ago

bektaskemal commented 1 year ago

Hi again, I made some changes mainly to:

set and use locations_file from the blackboard
load locations_file yaml only once in setLocations node
communicate locations info using ports

bektaskemal commented 1 year ago

This is looking great -- thank you for all the fixes.

I just have super minor stuff, but then should be good to approve :)

... I should really add pre-commit to this repo so I don't have to be manually pedantic, haha.

Fixed them, too. The formatting issues arose because I used a different format, and to avoid having diffs everywhere, I had to disable auto-formatting. Sorry for the inconvenience :)