Closed beahues closed 1 year ago
Thanks for reporting! We need to modify it so that it works even if the username is missing.
Your regex doesn't support https. (e.g. origin https://github.com/mycompany/repo (fetch)
)
https://regex101.com/r/JwGy8O/1
Feel free to open a PR 🙂
Made #108 which passes tests at the very least 😸
I just released v0.9.4! Please run gh ext upgrade poi
.
Describe the bug
When running against local SSH repos the regex at https://github.com/seachicken/gh-poi/blob/fdbd0f3241134c6def1a4706f438533211f6c48d/cmd/root.go#L153 doesn't match my remotes that do not start with
git@
:Testing that with the golang regex at https://regex101.com/r/6FqUBq/1 confirms this.
(I realise this is a simple fix my end, set the remote with the
git@
in it)Changing the regex to
appears to work for me, and passes tests, but it feels a very much "works for me" fix.
I can happily make https://github.com/beahues/gh-poi/commit/c27e54839b752fc75e730d77375a4bc29d51cd32 in to a PR though?
Your Environment
gh --version
):