seachicken / gh-poi

✨ Safely clean up your local branches
https://dev.to/seachicken/safely-clean-up-your-local-branches-9i3
MIT License
673 stars 19 forks source link

Split out remote regexp in to smaller parts #108

Closed beahues closed 1 year ago

beahues commented 1 year ago

By splitting by fields, we get a nice slice of [name URL purpose] which makes the regexp for matching a URL more manageable and work with github URLs without usernames #107

(sorry it's been about 4-5 years since I last touched any Go)

codecov[bot] commented 1 year ago

Codecov Report

Merging #108 (fc9d1a9) into main (fdbd0f3) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   81.79%   81.84%   +0.04%     
==========================================
  Files           4        4              
  Lines         758      760       +2     
==========================================
+ Hits          620      622       +2     
  Misses        114      114              
  Partials       24       24              
Impacted Files Coverage Δ
cmd/root.go 88.82% <100.00%> (+0.04%) :arrow_up:
seachicken commented 1 year ago

Looks very good, thanks! I will release it soon.