seachicken / gh-poi

✨ Safely clean up your local branches
https://dev.to/seachicken/safely-clean-up-your-local-branches-9i3
MIT License
642 stars 17 forks source link

Improved visibility in light mode #112

Closed rpadaki closed 11 months ago

rpadaki commented 11 months ago

This PR switches to using color.Bold instead of color.FgWhite, color.Bold. This is because the white+bold combination always renders as white, whether the terminal is in dark or light mode. By just using bold, we get the same output in dark mode but also get legible output in light mode.

Before and after (light) showing the fix

Screenshot 2023-10-03 at 11 42 24 AM

Before and after (dark) showing no regression

Screenshot 2023-10-03 at 11 43 24 AM
codecov[bot] commented 11 months ago

Codecov Report

Merging #112 (0818718) into main (1a50771) will not change coverage. The diff coverage is 37.50%.

@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   81.88%   81.88%           
=======================================
  Files           5        5           
  Lines         762      762           
=======================================
  Hits          624      624           
  Misses        114      114           
  Partials       24       24           
Files Coverage Δ
main.go 62.13% <37.50%> (ø)
seachicken commented 11 months ago

Wow! This is nice. Thank you

seachicken commented 11 months ago

I released it now at v0.9.7 🚀