seachicken / gh-poi

✨ Safely clean up your local branches
https://dev.to/seachicken/safely-clean-up-your-local-branches-9i3
MIT License
642 stars 17 forks source link

Text is invisible on light terminal themes #121

Closed monodera closed 4 months ago

monodera commented 4 months ago

Describe the bug

When I run gh poi, the text colors of terminal outputs are invisible for some messages for light terminal background colors. I'm not sure if this is because of my setting of the terminal or login shell (or maybe gh itself), but I'd like to know if there is a way to control the text colors of the output messages.

Here are a couple of examples:

With Ayu Mirage theme:

Screenshot 2024-04-26 at 10 56 49

With ayu_light theme:

Screenshot 2024-04-26 at 11 05 14

Your Environment

seachicken commented 4 months ago

Thank you for you're reporting! I had a similar issue before and it was fixed. https://github.com/seachicken/gh-poi/pull/112 gh poi is currently used by fatih/color for text colors, I think it's a problem with how to use this library, so I think it can be fixed.

main branch colors printing is here: https://github.com/seachicken/gh-poi/blob/920a5e6fbc0de2c59dd865a7fede0d0a827ff368/main.go#L199

I would like to check if there is a problem only with the white function. Could you also check the results of gh poi --help?

monodera commented 4 months ago

yes, I still have the issue with gh poi --help.

Screenshot 2024-05-02 at 20 08 44

However, the text is visible (still a bit low contrast) on Warp terminal with Ayu Light theme Screenshot 2024-05-02 at 22 02 49

I haven't checked whether any difference exists in the color configurations, but it may be related to the theme configuration of my iTerm2.

seachicken commented 4 months ago

@monodera Thanks for reporting it, I was able to fix it. Please run gh ext upgrade poi.

monodera commented 4 months ago

It worked! Thanks for quickly fixing it.