Closed hiroebe closed 1 year ago
Merging #81 (54aff6b) into main (cbf197b) will increase coverage by
0.07%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 88.29% 88.36% +0.07%
==========================================
Files 3 3
Lines 615 619 +4
==========================================
+ Hits 543 547 +4
Misses 54 54
Partials 18 18
Impacted Files | Coverage Δ | |
---|---|---|
main.go | 77.86% <100.00%> (+0.69%) |
:arrow_up: |
poi.go | 90.75% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Wow, I wasn't aware of the problem. Thanks for the great fix 😃
What
os.Interrupt
signal and propagate cancellation using contextdefer spinner.Stop()
to ensure that the spinner is stopped and cleaned upWhy
Current implementation does not handle keyboard interrupt, which causes unexpected side effect to the shell: When I input ctrl-c while a spinner is running (with the message
Fetching pull requests...
for example), the cursor is still hidden even after the command finished.