search

seadragon2000341 / pe

0 stars 0 forks source link

Constraint "must be a word" not upheld for t/ #2

Open seadragon2000341 opened 1 year ago

seadragon2000341 commented 1 year ago

add t/O d/Yummy i/Orange, 1, piece, 0.50 s/Juice the orange The command above will be valid, but O is not a word

I rate this severity.low as it is only a rare case whereby a user will type this - most wont be affected

nus-pe-script commented 1 year ago

Team's Response

Our error message does not specify what a word is.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Add Command: Instruction does not allow for dashes

I believe that titles should be allowed to accept hyphen-dashes, espcially since there are words that exist in the dictionary that have dashes.

Not frequent to have such words but may still confuse the user especially since the error message claims that a word/sentence was not given for the title when orange-juice is considered a word

image.png

[original: nus-cs2103-AY2223S2/pe-interim#2765] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is a feature flaw as we only take in alphanumeric and space when parsing user inputs for descriptions/titles/etc.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The other issue is phrased as a feature flaw ("titles should be allowed to accept hyphen-dashes"), but my issue is phrased as a functionality bug (user guide says input must be a word, but actual behaviour is that an alphabet (not a word) was accepted). Due to the different type of bugs, these are not duplicates. See the next section for more details.

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** It is a functionality bug as it is "A functionality does not work as specified/expected" - based on the rubrics Expected: Input must be a word. Actual: Able to add input that is not a word but an alphabet ("A") - > behaviour deviates from what is prescribed in the user guide