search

seadragon2000341 / pe

0 stars 0 forks source link

Edit command not working as intended #5

Open seadragon2000341 opened 1 year ago

seadragon2000341 commented 1 year ago

image.png

"Juicy Orange." is a sentence, so is should be allowed. I rate this severity.medium as it is highly likely that some users may use full stops in their sentences

nus-pe-script commented 1 year ago

Team's Response

Title and description fields work the same way

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Add Command: Instruction does not allow for dashes

I believe that titles should be allowed to accept hyphen-dashes, espcially since there are words that exist in the dictionary that have dashes.

Not frequent to have such words but may still confuse the user especially since the error message claims that a word/sentence was not given for the title when orange-juice is considered a word

image.png

[original: nus-cs2103-AY2223S2/pe-interim#2765] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is a feature flaw as we only take in alphanumeric and space when parsing user inputs for descriptions/titles/etc.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The other issue is phrased as a feature flaw ("titles should be allowed to accept hyphen-dashes"), but my issue is phrased as a functionality bug (user guide say sentences can be accepted for the t/ field in an edit command, but actual behaviour is that sentences were not accepted). Due to the different type of bugs, these are not duplicates. See the next section for more details.

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** It is a functionality bug as it is "A functionality does not work as specified/expected" - based on the rubrics. Expected: Able to input sentences to the t/field in the edit command as specified in the user guide Actual: Unable to add sentence ("Juicy Orange.") - > behaviour deviates from what is prescribed in the user guide
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** severity.Medium : A flaw that causes occasional inconvenience to some users but they can continue to use the product. Users who want to add sentences **which includes punctuations** like the one above (Orange Juice.) in the t/ field of the edit command are unable to do so. It causes occasional inconvenience to such users (need to rephrase/change the sentence), but they can continue to use the product. This fits into the description of severity.medium.